CI 및 브랜치별 CD 배포 파이프라인 정리#20
Merged
Merged
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the docker-compose.yml file to use a pre-built image instead of building from the local Dockerfile. The review feedback suggests retaining the build configuration alongside the image property to maintain flexibility for local development while still supporting CI/CD image overrides.
| build: | ||
| context: . | ||
| dockerfile: Dockerfile | ||
| image: ${IMAGE_NAME:-ghcr.io/team-triple/triple_yjs}:${IMAGE_TAG:-develop} |
There was a problem hiding this comment.
로컬 개발 환경에서의 편의성을 위해 build 설정을 유지하는 것을 권장합니다. build와 image를 함께 정의하면, 로컬에서는 docker-compose up --build를 통해 소스 코드 변경 사항을 즉시 반영하여 테스트할 수 있으며, 동시에 CI/CD 환경에서는 환경 변수를 통해 주입된 이미지 이름을 사용할 수 있어 유연성이 높아집니다.
build:
context: .
dockerfile: Dockerfile
image: ${IMAGE_NAME:-ghcr.io/team-triple/triple_yjs}:${IMAGE_TAG:-develop}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.